2 dootronics having the same ID?

×

Missatge d'estat

You are not a member of this team. If you want to be part of this team, click on 'Subscribe to this team'.
imatge de Rhein-Ruhr-Hub
Enviat per Rhein-Ruhr-Hub el dj., 05/18/2017 - 10:38
Equip/s: 
Software Development
Tipus: 
Website bug
Estat: 
Resolved
Prioritat: 
Normal
Descripció: 

Hi Jordi,

wanted to change the status for a recycled laptop. But I was not able to update the dootronic entry, as it exists twice (error "The alias is already in use.". You are only able to see it starting here https://www.labdoo.org/de/content/dootronics-dashboard and filter for "10107". Then you will see that 2 laptops have the same ID.
Zürich: not possible to enter to edit
Rhein-Ruhr: https://www.labdoo.org/node/40442/edit
Labdoo ID Status Hub Edoovillage Country
1 ...(not interesting)
2 000010107 S2 Labdoo Hub Zürich (Schweiz) Switzerland
3 000010107 S1 Labdoo Hub Rhein-Ruhr Germany

You may delete the hub Rhein-Ruhr entry and keep Franks, as mine was recycled anyway.

No idea, how this was possible.

Thanks, Ralf

Comentaris

imatge de jordi
Enviat per jordi el ds., 05/20/2017 - 04:51

Yeah! that's exactly what happened :)

It took us 10,000 laptops to have the first ever laptop tagging collision, and following the law of large numbers, it happened between the two most active countrires Germany and Switzerland :).

One dootronic was tagged at Fri, 5 May 2017 05:41:52 -0700 (PDT)

The other was tagged at Fri, 5 May 2017 05:41:55 -0700 (PDT)

So just 3 seconds apart. (See attached email screenshots)

There is a very unlikely (but possible with a very small probability, say 1 out of 10000 :) ) racing condition. While rare, this needs a proper fix. Thank you for reporting.

In the meantime, per Ralf indications, i have removed Ralf's version of 000010107.

Good catch and thanks for reporting this!

Attachment: 

imatge de wendy
Enviat per wendy el dl., 10/23/2017 - 05:35

Hi Jordi,

It happens again. Please see the attached picture.

When you find time, can you help clone the duplicate one to a different Labdoo ID since they were created by 2 different users, I hope both taggers get to receive laptop status on the laptops they tagged.

Thanks!

Attachment: 

imatge de jordi
Enviat per jordi el dv., 11/10/2017 - 10:32

Thanks for reporting, this was another laptop tagging collision, occurring with Ralf and Elena tagging a laptop at the same time on "Thu, Nov 9, 2017 at 5:56 PM". I am working on a fix to this problem, it's going to take me a few more days to have this fixed, but it's one of the top priorities right now. Thanks.
PS: Elena i have removed the extra laptop, so the database should be clean now.

imatge de jordi
Enviat per jordi el dt., 11/21/2017 - 08:58

This is now resolved.

For internal records, i have added the next three new functions that help us provide a locking mechanism within Labdoo to protect collisions when multiple objects are created at the same time. These were very unlikely in the past (chances were about 4 every 10,000 laptops, so about 0.04%), but now they should never happen again.

lbd_lock_acquire(), lbd_lock_release(), labdoo_lib_lock_thread()

See: https://github.com/Labdoo/Labdoo/blob/1109b6c85213df72702437b35750924897...

Right now we only use this lock to protect dootronics, dootrips and edoovillages, which are the only objects that require ID numbers.

Commit: https://github.com/Labdoo/Labdoo/commit/1109b6c85213df72702437b357509248...