Ensure "Delivered" metric includes historical values

Enviat per jordi el ds., 11/09/2019 - 22:45

Equip/s:

Software Development

Tipus:

Website bug

Estat:

Open

Prioritat:

Normal

Descripció:

Javier recently made a question that made us realize our "Delivered" counter underestimates the actual values of delivered laptops. This is because a laptop delivered (S4) that later on is recycled (S6) stops counting as delivered.

The metric should look at all the historical states taken by a laptop to truly capture the right number of laptops delivered.

Comentaris

Enviat per jordi el ds., 11/09/2019 - 22:46 Enllaç permanent

This is now fixed: https:/

This is now fixed: https://github.com/Labdoo/Labdoo/commit/655f8a3c812fe6c3cf0f23d943a45925...

Thanks Javier for catching this error!

Inicieu sessió o registreu-vos per a enviar comentaris

Enviat per jprisab el dg., 11/10/2019 - 10:05 Enllaç permanent

Thanks for the fast reply

Hi,
Thanks for a fast reply...

as told, maybe it is worth to re-think all the statistics and concepts for a future release...but so far it will do it!

Best Regards

Javier

Inicieu sessió o registreu-vos per a enviar comentaris

Enviat per t810sable el dt., 11/12/2019 - 16:25 Enllaç permanent

Javier - Not sure how you

Javier - Not sure how you found this out but great!
Jordi - Thanks for fixing this quickly.

I couldn't interpret the code in GitHub but only the devices from S4 to S6 will be counted as delivered? The reason I am asking is sometimes I move S1 to S6 (or S1 to S5 to S6) after noticing the donated laptop cannot be reused. Also hope changing these laptops from S1 to S5/S6 is the correct process. Just double checking.

Kazushi